meta.reviews.selector_whole_file

Selector::WholeFile selects all contents of the fragment’s source file, including any trailing newline. It carries no additional selector data.

Read in specification context · design/meta/reviews.md

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

Implemented sage_meta::whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.selector_whole_file)]
#[sage::test(meta.reviews.selector_line_range)]
#[sage::test(meta.reviews.recorded_reads)]
#[sage::test(meta.reviews.fragment_freshness)]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.input_fragments)]
#[sage::test(meta.reviews.source_representation)]
#[sage::test(meta.reviews.staleness)]
fn whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits() {
    let fixture = Fixture::new();
    fixture.start();
    fixture.write("helper.txt", "first\r\n\r\nthird\nlast");
    assert_eq!(
        review::capture_read(
            &fixture.0,
            "demo.rule",
            "helper.txt",
            Selector::LineRange { start: 1, end: 2 }
        )
        .unwrap(),
        "first\r\n\r\n"
    );
    assert_eq!(
        review::capture_read(
            &fixture.0,
            "demo.rule",
            "helper.txt",
            Selector::LineRange { start: 4, end: 4 }
        )
        .unwrap(),
        "last"
    );
    for (start, end) in [(0, 1), (3, 2), (1, 5), (5, 5)] {
        assert!(
            review::capture_read(
                &fixture.0,
                "demo.rule",
                "helper.txt",
                Selector::LineRange { start, end }
            )
            .is_err()
        );
    }
    review::record(&fixture.0, "demo.rule", &Fixture::report()).unwrap();
    fixture.write("helper.txt", "first\r\n\r\nUNSELECTED\nlast");
    assert!(sage_meta::check(&fixture.0).is_valid());
    fixture.write("helper.txt", "changed\r\n\r\nthird\nlast");
    assert!(!sage_meta::check(&fixture.0).is_valid());
    fixture.start();
    for _ in 0..2 {
        assert_eq!(
            review::capture_read(&fixture.0, "demo.rule", "helper.txt", Selector::WholeFile)
                .unwrap(),
            "changed\r\n\r\nthird\nlast"
        );
    }
    let input = fixture.input();
    let tail = &input.fragments[input.fragments.len() - 2..];
    assert_eq!(tail[0], tail[1]);
    assert_eq!(tail[0].contents.join("\n"), "changed\r\n\r\nthird\nlast");
    review::record(&fixture.0, "demo.rule", &Fixture::report()).unwrap();
    fixture.write("helper.txt", "changed\r\n\r\nthird\nlast\n");
    assert!(!sage_meta::check(&fixture.0).is_valid());
}
}

See more source ↗

Review: Accepted · anchor_094 fresh final review.

Reviewed the full selector_whole_file claim, its ordinary implementation in review.rs and the complete associated ordinary whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits test. No TODO/N/A entries exist. Captured the fixture helper dependency.

The requirements are narrow: WholeFile selects all source-file text including any final newline and carries no additional selector data. Selector declares WholeFile as a unit variant under the tagged enum, with no range/identity payload. select resolves the fragment path and directly returns read_to_string without trimming, splitting lines, normalizing line endings or omitting a final delimiter. The path remains in InputFragment rather than being duplicated as selector data. Missing/unreadable/non-UTF8 files return errors rather than partial content.

capture_read saves the selected string via source_lines, which splits only on newline and preserves a terminal empty element, CR characters and blank lines. Rejoining saved contents with newline reconstructs the exact selected text. input_errors rereads an additional WholeFile with the same selector and compares the reconstructed saved string exactly; initial associated implementation WholeFiles are freshly rebuilt by inventory and compared in the initial prefix. This preserves the all-content scope through saving and checking rather than merely returning the right string once.

The test first establishes nearby LineRange behavior using mixed CRLF/LF, blank lines and an unterminated final line, then starts a fresh review and captures WholeFile twice. Each return must equal the complete expected mixed-line-ending file, both appended fragments must match, and joined saved contents must equal the entire source. After recording it adds only a final newline and asserts the gate becomes invalid. That final assertion would fail if WholeFile or its storage/freshness path discarded the trailing newline. The range portion separately demonstrates unselected changes may remain valid only for the range selector; it is not asserted as WholeFile behavior. Fixture helpers create actual files and production review/check records, while exact text comparisons are visible in the test body.

Source inspection of the unit variant accounts for the no-additional-data qualification; the direct full-file read and newline-sensitive test account for complete text capture. No source changes, suspected defect or additional edits were needed. This pass executed review start/read/record and source inspection only; no behavioral tests were rerun, and central suite results are not claimed as this reviewer's execution. Dependency capture is complete. No requested edits.

Browse meta anchors

116 anchors

Anchor Implementation Tests

meta (116) 102 Implemented24 TODO 103 Implemented36 TODO

meta.anchors (22) 22 Implemented 21 Implemented12 TODO

anchor_pages Implemented ImplementedTODO

Every specification anchor has a stable page identifying the rule and showing its definition, context, implementation entries, and tests/evidence. The page includes Rust excerpts and access to surrounding source, and exposes each entry’s placeholder status and explanation. Multiple sites remain individually inspectable rather than being reduced to a single coverage badge.

Symposiun AGentic Environment (SAGE)

meta.reviews.selector_whole_file

Implementation

Tests and review