crates.sage_inspector.inspection.unknown_work

Unknown work is visible rather than omitted. Supported Sage and metadata operations use stable operation families; any query without a semantic-key projection is retained as unmapped with its raw diagnostic ingredient. A checked closed dependency claim fails in the presence of an unexpected fallback.

Read in specification context · design/crates/sage_inspector/inspection.sage

Implementation

Implemented crates/sage-host/src/trace.rs:5–10

sage_host::trace · lib:sage_host

#![allow(unused)]
fn main() {
// {anchor}`crates.sage_inspector.inspection.unknown_work`
pub fn build_dynamic_trace(
    events: Vec<sage_ir::db::InspectionEvent>,
    default_phase: TracePhase,
) -> Vec<TraceNode> {
    let mut roots = Vec::new();

}

See more source ↗

TODO crates/sage-meta/tests/service_spec.rs:117–122

sage_meta::todo · test:service_spec

TODO: Closed dependency claim checking is absent. It needs an API accepting the complete projected trace and allowed operations, recursively rejecting unexpected unmapped query or metadata nodes without filtering them. Ordinary trace projection already retains these nodes.

#![allow(unused)]
fn main() {
    // {anchor}`crates.sage_inspector.inspection.unknown_work`
    // TODO: Closed dependency claim checking is absent. It needs an API accepting the complete
    // projected trace and allowed operations, recursively rejecting unexpected unmapped query or
    // metadata nodes without filtering them. Ordinary trace projection already retains these nodes.

    #[test]

}

See more source ↗

Implemented src/inspector.rs:547–552

sage::inspector · lib:sage

#![allow(unused)]
fn main() {
// {anchor}`crates.sage_inspector.inspection.unknown_work`
use sage_host::trace::build_dynamic_trace;

fn revision_summary(revision: &RetainedRevision) -> RevisionSummary {
    RevisionSummary {
        revision_id: revision.revision_id.clone(),

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

TODO sage_meta::todo::crates_sage_inspector_inspection_unknown_work

crates/sage-meta/tests/service_spec.rs · test:service_spec

#![allow(unused)]
fn main() {
#[test]
    #[sage::test(crates.sage_inspector.inspection.unknown_work)]
    fn crates_sage_inspector_inspection_unknown_work() {
        // TODO: Associate and review the complete evidence for Real traces include all balanced Salsa
        // requests and metadata calls, and forbidden-demand tests cannot pass by filtering an unknown
        // node. Closed-claim rejection tests require the missing complete-trace checking API above;
        // they must include an unexpected nested unmapped query and metadata operation.
    }
}

See more source ↗

Review: Accepted · Codex anchor_037 refresh.

Fresh source review of the complete claim and all current associations. The four obligations are visibility of unknown work, stable Sage/metadata operation families, raw diagnostic ingredients retained in unmapped query keys when semantic projection is unavailable, and rejection of unexpected fallback by checked closed dependency claims.

The ordinary src/inspector.rs association identifies the adapter importing build_dynamic_trace. LiveInspectionProvider::record takes the inspection log, projects every supplied event, stores the returned children in RunObservation, and run returns that stored observation without removing unmapped nodes. The ordinary crates/sage-host/src/trace.rs association supplies the actual projection: QueryEnter and QueryLeaf move the original key into TraceKey::Unmapped; QueryExit attaches the completed node and does not strip its key. query_operation strips parenthesized arguments and surrounding whitespace from the family only. A key without parentheses still becomes an unmapped node with its original ingredient. ExternalMetadata keeps the complete operation string as ingredient while using the prefix as its family. Semantic phase/span events keep their producer-authored operation names. attach_trace_node retains nested as well as root work; unordered normalization only sorts. Outstanding stack nodes are drained, and malformed exits add visible unmapped recorder-error diagnostics. Executed, validated, reused and cancelled dispositions remain represented. The protocol's tagged TraceKey representation explicitly serializes Unmapped and its ingredient. snapshot_trace normalizes the ingredient to its operation for deterministic test snapshots; live Inspector record uses build_dynamic_trace directly, so that separate normalization does not erase its raw diagnostics.

The third implementation entry is explicitly TODO in sage_meta::todo, service_spec.rs. It accurately states that closed dependency claim checking is absent, and requires an API accepting the complete projected trace and allowed operations, recursively rejecting unexpected unmapped query/metadata nodes without filtering. This narrow implementation deferral is justified and remains visibly deferred: the ordinary projection entries establish retention, not closed-check enforcement. No claim of full implementation is made.

The complete associated test set contains only sage_meta::todo::crates_sage_inspector_inspection_unknown_work. The entire body consists of TODO comments and supplies no executable assertions. It explicitly defers real-trace evidence for all balanced Salsa requests and metadata calls, plus tests preventing forbidden-demand checks from filtering unknown nodes. It names the missing complete-trace checking API as prerequisite and requires nested unexpected queries and metadata scenarios. Accepting this TODO does not claim any test coverage or successful enforcement. To close it, associated source-driven trace tests must assert retained raw ingredients and stable operation families, and checker tests must demonstrate rejection of unexpected nested fallback. No N/A entries exist.

All requirements are accounted for by current ordinary projection evidence or the explicit implementation/test deferrals. No additional edits are requested for this review refresh. Ran cargo meta review start/read and inspected the current captured implementation, complete test body, association metadata, and protocol dependency; behavior suites are centrally owned by root and were not run by this reviewer. No Rust source was changed and no reproduced behavioral failure is claimed.

Browse crates anchors

139 anchors

Specification anchors and declared coverage
AnchorImplementationTests
crates (139)114 Implemented37 TODO2 N/A74 Implemented107 TODO
crates.sage_inspector (15)13 Implemented1 TODO2 N/A3 Implemented15 TODO
crates.sage_inspector.inspection (15)13 Implemented1 TODO2 N/A3 Implemented15 TODO
balanced_tracesImplementedTODO
canonical_ownershipImplementedImplementedTODO
derive_reflectionImplementedImplementedTODO
detail_free_indexImplementedTODO
deterministic_traceImplementedTODO
durable_navigationN/ATODO
generic_browserN/ATODO
owned_reflectionImplementedImplementedTODO
product_availabilityImplementedTODO
revision_and_demandImplementedTODO
semantic_phase_boundaryImplementedTODO
source_evidenceImplementedTODO
typed_serviceImplementedTODO
unknown_workImplementedTODOTODO
workspace_actorImplementedTODO
crates.sage_ir (90)67 Implemented34 TODO40 Implemented88 TODO
crates.sage_ir.checking (12)12 Implemented3 TODO5 Implemented12 TODO
crates.sage_ir.checking.body (5)5 Implemented2 TODO3 Implemented5 TODO
elaborationImplementedImplementedTODO
expected_typesImplementedTODOTODO
interface_dependenciesImplementedImplementedTODO
isolated_completionImplementedImplementedTODO
operator_callsImplementedTODOTODO
identity_mintingImplementedTODO
owned_productsImplementedImplementedTODO
crates.sage_ir.checking.signature (4)4 Implemented1 TODO1 Implemented4 TODO
body_independenceImplementedTODO
narrow_detailImplementedTODOTODO
owner_binderImplementedImplementedTODO
storageImplementedTODO
symbol_keyed_interfacesImplementedTODO
crates.sage_ir.crate (9)9 TODO9 TODO
explicit_restrictionsTODOTODO
identity_before_detailTODOTODO
incremental_evidenceTODOTODO
narrow_demandsTODOTODO
reexecution_and_invalidationTODOTODO
represented_completenessTODOTODO
restrictions_and_gapsTODOTODO
semantic_query_boundariesTODOTODO
terminal_incompletenessTODOTODO
crates.sage_ir.inference (8)8 Implemented6 Implemented8 TODO
atomic_checkingImplementedImplementedTODO
body_local_quiescenceImplementedImplementedTODO
canonical_boundaryImplementedImplementedTODO
completed_body_boundaryImplementedTODO
numeric_domainsImplementedImplementedTODO
subtyping_and_coercionImplementedImplementedTODO
terminal_obligationsImplementedTODO
transaction_isolationImplementedImplementedTODO
crates.sage_ir.metadata (4)4 Implemented1 TODO4 TODO
explicit_incompletenessImplementedTODO
keyed_reuseImplementedTODOTODO
product_boundariesImplementedTODO
provider_authorityImplementedTODO
crates.sage_ir.modules (8)7 Implemented1 TODO4 Implemented8 TODO
crates.sage_ir.modules.expand (4)4 Implemented2 Implemented4 TODO
completenessImplementedImplementedTODO
dependenciesImplementedTODO
direct_membersImplementedTODO
recursion_and_fixpointImplementedImplementedTODO
crates.sage_ir.modules.parse (4)3 Implemented1 TODO2 Implemented4 TODO
dependenciesImplementedTODO
detail_firewallImplementedImplementedTODO
recovery_completenessTODOTODO
syntax_identitiesImplementedImplementedTODO
crates.sage_ir.resolution (5)5 Implemented1 TODO3 Implemented4 TODO
crates.sage_ir.resolution.lookup (5)5 Implemented1 TODO3 Implemented4 TODO
completenessImplementedTODOImplementedTODO
dependenciesImplementedTODO
expansion_import_ambiguityImplementedImplemented
identity_onlyImplementedTODO
precedenceImplementedImplementedTODO
crates.sage_ir.solver (9)7 Implemented7 TODO5 Implemented9 TODO
alternative_isolationImplementedTODOImplementedTODO
bounded_completenessImplementedTODOTODO
candidate_completenessImplementedTODO
canonical_cyclesTODOTODO
canonical_outputsImplementedImplementedTODO
local_index_firewallTODOTODO
normalization_demandImplementedTODOImplementedTODO
schedule_independenceImplementedTODOImplementedTODO
shared_final_resultImplementedTODOImplementedTODO
crates.sage_ir.symbols (8)8 Implemented4 Implemented7 TODO
associated_identityImplementedImplemented
associated_interfacesImplementedTODO
body_interfacesImplementedImplementedTODO
definition_identityImplementedTODO
external_fact_queriesImplementedTODO
external_identityImplementedTODO
kind_wrappersImplementedImplementedTODO
local_identityImplementedImplementedTODO
crates.sage_ir.types (27)16 Implemented12 TODO13 Implemented27 TODO
crates.sage_ir.types.aliases (2)1 Implemented1 TODO1 Implemented2 TODO
identityImplementedImplementedTODO
revelationTODOTODO
crates.sage_ir.types.binder (1)1 Implemented1 TODO1 Implemented1 TODO
owner_parametersImplementedTODOImplementedTODO
crates.sage_ir.types.body (13)4 Implemented9 TODO3 Implemented13 TODO
awaitTODOTODO
closuresTODOTODO
conditional_patternsTODOTODO
coroutinesTODOTODO
diagnosed_recoveryImplementedImplementedTODO
elaboratedTODOImplementedTODO
for_iterationTODOTODO
indexingTODOTODO
macro_expansionTODOTODO
no_inferenceImplementedImplementedTODO
resolved_referencesImplementedTODO
try_residualTODOTODO
typed_provenanceImplementedTODO
crates.sage_ir.types.calls (2)1 Implemented1 TODO1 Implemented2 TODO
dispatch_familiesTODOTODO
selected_semanticsImplementedImplementedTODO
crates.sage_ir.types.lifetimes (2)2 Implemented2 Implemented2 TODO
dummyImplementedImplementedTODO
unchecked_borrowsImplementedImplementedTODO
crates.sage_ir.types.operators (2)2 Implemented1 Implemented2 TODO
lazy_control_flowImplementedTODO
trait_callsImplementedImplementedTODO
scoped_identitiesImplementedTODO
crates.sage_ir.types.spans (4)4 Implemented4 Implemented4 TODO
generated_identityImplementedImplementedTODO
item_originImplementedImplementedTODO
offset_reuseImplementedImplementedTODO
relative_compositionImplementedImplementedTODO
crates.sage_oracle_harness (4)4 Implemented2 TODO1 Implemented4 TODO
crates.sage_oracle_harness.crate (4)4 Implemented2 TODO1 Implemented4 TODO
deterministic_emissionImplementedTODO
exact_comparisonImplementedTODOImplementedTODO
fixed_projectionImplementedTODO
independent_coverageImplementedTODOTODO
crates.sage_stash (5)5 Implemented5 Implemented
crates.sage_stash.storage (5)5 Implemented5 Implemented
handle_ownershipImplementedImplemented
immutable_entriesImplementedImplemented
query_valueImplementedImplemented
rooted_equalityImplementedImplemented
typed_interningImplementedImplemented
crates.sage_test_harness (25)25 Implemented25 Implemented
crates.sage_test_harness.compile_tests (25)25 Implemented25 Implemented
annotation_validationImplementedImplemented
blessing_gateImplementedImplemented
callsite_updatesImplementedImplemented
checking_scopeImplementedImplemented
compiler_conditionsImplementedImplemented
completed_typesImplementedImplemented
coordinatesImplementedImplemented
dependenciesImplementedImplemented
diagnostic_countsImplementedImplemented
diagnostic_locationsImplementedImplemented
editionImplementedImplemented
fixturesImplementedImplemented
grouped_observationsImplementedImplemented
invocationImplementedImplemented
production_executionImplementedImplemented
project_isolationImplementedImplemented
query_captureImplementedImplemented
query_projectionImplementedImplemented
renderingImplementedImplemented
resolved_symbolsImplementedImplemented
review_visibilityImplementedImplemented
rustc_executionImplementedImplemented
rustc_lintsImplementedImplemented
starting_expressionsImplementedImplemented
target_lineImplementedImplemented