meta.reviews.review_scope

One review judges both implementation completeness and test adequacy against an anchor’s complete claim. Its saved input includes every implementation association’s crate, target, module, file, cfg conditions, excerpt, region flag, placeholder status, and explanation, in deterministic order. Source line numbers and byte offsets are not association metadata. Source context used to assess these associations is recorded under meta.reviews.input_fragments. A point marker’s five-line preview is navigation context, not a sufficient boundary for reviewing behavior that depends on other code.

Reviewers follow relevant helpers and dependencies and record the source fragments they use. They add implementation associations for essential code in other files before approval. Reviews are source judgments, not proofs; test execution remains separate evidence.

Read in specification context · design/meta/reviews.md

Implementation

Implemented crates/sage-meta/src/review.rs:153–158

sage_meta::review · lib:sage_meta

#![allow(unused)]
fn main() {
// {anchor}`meta.reviews.review_scope`
// {anchor}`meta.book.index_status`
pub fn inventory(
    spec: &SpecIndex,
    rust: &CorrespondenceIndex,
) -> Result<BTreeMap<String, ReviewInput>, Box<dyn Error>> {

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

Implemented sage_meta::accepted_placeholder_reports_preserve_todo_and_na_evidence

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.decisions)]
#[sage::test(meta.reviews.review_scope)]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.test_source)]
fn accepted_placeholder_reports_preserve_todo_and_na_evidence() {
    for (module, expected) in [
        ("todo", TestStatus::Todo),
        ("not_applicable", TestStatus::NotApplicable),
    ] {
        let fixture = Fixture::new();
        fixture.write("src/behavior.rs", &format!("mod {module} {{\n// {{anchor}}`demo.rule`\n// Deferred until the concrete backend exists; editorial for N/A.\nfn placeholder() {{}}\n}}"));
        fixture.write("src/tests.rs", &format!("mod {module} {{\n// Deferred until the concrete backend exists; editorial for N/A.\n#[test] #[sage::test(demo.rule)] fn placeholder() {{}}\n}}"));
        let input = fixture.start();
        assert_eq!(input.tests[0].status, expected);
        assert_eq!(input.implementations[0].status, expected);
        assert!(
            input.implementations[0]
                .explanation
                .as_ref()
                .unwrap()
                .contains("backend")
        );
        let mut output = Fixture::report();
        output.report = "The explicit placeholder explains why concrete evidence is unavailable and names its prerequisite. This accepts the stated gap, not implemented behavior.".into();
        review::record(&fixture.0, "demo.rule", &output).unwrap();
        let check = sage_meta::check(&fixture.0);
        assert!(check.is_valid());
        let stage = check.review.unwrap();
        assert_eq!(stage.approved, 0);
        assert_eq!(
            (stage.todo, stage.not_applicable),
            if module == "todo" { (1, 0) } else { (0, 1) }
        );
    }
}
}

See more source ↗

Implemented sage_meta::implementation_metadata_is_sorted_and_excludes_source_positions

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.review_scope)]
fn implementation_metadata_is_sorted_and_excludes_source_positions() {
    let fixture = Fixture::new();
    let alpha = "mod alpha {\n// {anchor}`demo.rule`<<\npub fn result() -> u32 { 4 }\n// >>\n}\n";
    let zeta = "mod zeta {\n// {anchor}`demo.rule`<<\npub fn result() -> u32 { 4 }\n// >>\n}\n";
    fixture.write("src/behavior.rs", &format!("{zeta}{alpha}"));
    let first = fixture.start();
    assert_eq!(
        first
            .implementations
            .iter()
            .map(|site| site.module.as_str())
            .collect::<Vec<_>>(),
        ["demo::behavior::alpha", "demo::behavior::zeta"]
    );
    for site in &first.implementations {
        let value = serde_json::to_value(site).unwrap();
        let mut keys = value
            .as_object()
            .unwrap()
            .keys()
            .map(String::as_str)
            .collect::<Vec<_>>();
        keys.sort();
        assert_eq!(
            keys,
            [
                "cfg",
                "crate_name",
                "excerpt",
                "explanation",
                "file",
                "module",
                "region",
                "status",
                "target"
            ]
        );
    }
    fixture.write(
        "src/behavior.rs",
        &format!("// Unrelated leading context moves source positions.\n\n{alpha}{zeta}"),
    );
    let moved = fixture.start();
    assert_eq!(moved.implementations, first.implementations);
    // Whole-file context still changes; position independence applies to metadata.
    assert_ne!(moved.fragments, first.fragments);
}
}

See more source ↗

Implemented sage_meta::initial_context_preserves_instructions_and_exact_uniform_fragments

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.input_fragments)]
#[sage::test(meta.reviews.fragment_format)]
#[sage::test(meta.reviews.review_instructions)]
#[sage::test(meta.reviews.review_scope)]
#[sage::test(meta.reviews.source_representation)]
#[sage::test(meta.reviews.preparation)]
fn initial_context_preserves_instructions_and_exact_uniform_fragments() {
    let fixture = Fixture::new();
    let instructions = vec![
        "Check all scenarios.\nKeep this newline.".into(),
        "Account for TODO rationale.".into(),
    ];
    let input = review::start(&fixture.0, "demo.rule", instructions.clone()).unwrap();
    assert_eq!(input.coordinator_instructions, instructions);
    assert_eq!(input.prompt, review::PROMPT);
    assert_eq!(input, fixture.input());
    let claim = input
        .fragments
        .iter()
        .find(|f| matches!(&f.selector, Selector::Claim { anchor_id } if anchor_id == "demo.rule"))
        .unwrap();
    assert_eq!(claim.path, "md/design/README.md");
    assert_eq!(claim.contents.join("\n"), "The result is four.");
    let implementation = input
        .fragments
        .iter()
        .find(|f| f.path == "src/behavior.rs" && matches!(f.selector, Selector::WholeFile))
        .unwrap();
    assert_eq!(
        implementation.contents.join("\n"),
        std::fs::read_to_string(fixture.0.join("src/behavior.rs")).unwrap()
    );
    let test = input
        .fragments
        .iter()
        .find(|f| matches!(f.selector, Selector::Test { .. }))
        .unwrap();
    assert_eq!(test.path, "src/tests.rs");
    assert_eq!(test.contents.join("\n"), TEST);
    assert!(
        !input
            .fragments
            .iter()
            .any(|f| f.path == "src/tests.rs" && matches!(f.selector, Selector::WholeFile))
    );
    assert_eq!(input.implementations.len(), 1);
    assert_eq!(input.implementations[0].file, "src/behavior.rs");
    assert_eq!(input.implementations[0].status, TestStatus::Ordinary);
    assert_eq!(input.tests.len(), 1);
}
}

See more source ↗

Implemented sage_meta::input_keeps_complete_association_metadata_and_appends_context_in_one_collection

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.review_scope)]
#[sage::test(meta.reviews.input_fragments)]
#[sage::test(meta.reviews.preparation)]
fn input_keeps_complete_association_metadata_and_appends_context_in_one_collection() {
    let fixture = Fixture::new();
    fixture.write(
        "src/lib.rs",
        "#[sage::item(crate)] mod model {}\n#[cfg(unix)] mod behavior;\n#[cfg(test)] mod tests;\n",
    );
    let initial = fixture.start();
    let implementation = &initial.implementations[0];
    assert_eq!(implementation.crate_name, "demo");
    assert_eq!(implementation.target, "lib:demo");
    assert_eq!(implementation.module, "demo::behavior");
    assert_eq!(implementation.file, "src/behavior.rs");
    assert!(implementation.cfg.iter().any(|cfg| cfg.contains("unix")));
    assert!(
        implementation
            .excerpt
            .join("\n")
            .contains("pub fn result() -> u32 { 4 }")
    );
    assert!(!implementation.region);
    assert_eq!(implementation.status, TestStatus::Ordinary);
    assert_eq!(implementation.explanation, None);
    let test = &initial.tests[0];
    assert_eq!(test.crate_name, "demo");
    assert_eq!(test.target, "lib:demo");
    assert_eq!(test.rust_path, "demo::tests::verifies_result");
    assert_eq!(test.file, "src/tests.rs");
    assert!(test.cfg.iter().any(|cfg| cfg.contains("test")));
    assert_eq!(test.status, TestStatus::Ordinary);
    fixture.write("helper.txt", "extra context\n");
    assert_eq!(
        review::capture_read(&fixture.0, "demo.rule", "helper.txt", Selector::WholeFile).unwrap(),
        "extra context\n"
    );
    let captured = fixture.input();
    assert_eq!(captured.implementations, initial.implementations);
    assert_eq!(captured.tests, initial.tests);
    assert_eq!(
        &captured.fragments[..initial.fragments.len()],
        initial.fragments
    );
    assert_eq!(captured.fragments.len(), initial.fragments.len() + 1);
    assert_eq!(
        captured.fragments.last().unwrap().contents.join("\n"),
        "extra context\n"
    );
    let json = serde_json::to_value(&captured).unwrap();
    let mut keys: Vec<_> = json
        .as_object()
        .unwrap()
        .keys()
        .map(String::as_str)
        .collect();
    keys.sort();
    assert_eq!(
        keys,
        [
            "coordinator_instructions",
            "fragments",
            "implementations",
            "prompt",
            "tests"
        ]
    );
}
}

See more source ↗

Implemented sage_meta::region_association_preserves_placeholder_explanation_and_excerpt

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.review_scope)]
fn region_association_preserves_placeholder_explanation_and_excerpt() {
    let fixture = Fixture::new();
    fixture.write("src/behavior.rs", "mod todo {\n// {anchor}`demo.rule`<<\n// TODO: Implement arithmetic after the numeric type model is available.\npub fn result() -> u32 { 4 }\n// >>\n}\n");
    let input = fixture.start();
    let site = &input.implementations[0];
    assert!(site.region);
    assert_eq!(site.module, "demo::behavior::todo");
    assert_eq!(site.status, TestStatus::Todo);
    assert!(
        site.explanation
            .as_ref()
            .unwrap()
            .contains("numeric type model")
    );
    let excerpt = site.excerpt.join("\n");
    assert!(excerpt.contains("pub fn result() -> u32 { 4 }"));
    assert!(excerpt.contains("TODO: Implement arithmetic"));
    let saved = fixture.input();
    assert_eq!(saved.implementations, input.implementations);
}
}

See more source ↗

Review: Accepted · final_quality.

Fresh followup review of meta.reviews.review_scope. Preserved the previous input/output, started a new review, read the complete claim and all five associated test bodies, and recaptured the prior dependencies: review fixture helpers lines 1–94, review workflow design, and sage-review-checklist skill. Compared all prior/current fragments by path and selector and compared implementation/test metadata. Only a placeholder_status association comment in review.rs and a test_source attribute on accepted_placeholder_reports_preserve_todo_and_na_evidence changed. No behavior, assertion, claim, helper, metadata for this anchor, or dependency changed; no fragments were removed. These additions do not alter the complete prior assessment below.

The sole ordinary implementation association covers inventory in review.rs. It creates one ReviewInput for an anchor containing its complete claim, all implementation associations, whole implementation-file context and complete associated test functions. ReviewImplementation serializes exactly crate_name, target, module, file, cfg, excerpt, region, status, explanation; no line or byte positions appear. Its derived ordering and inventory sort/dedup make metadata deterministic. Whole-file capture ensures a point preview is not the behavioral boundary. capture_read appends dependency fragments; input_errors validates initial captures and reselects additional reads, and record preserves saved input rather than replacing it. PROMPT and the captured skill require one judgment of both implementation completeness and test adequacy against every claim aspect, following/capturing relevant helpers and adding associations for essential code elsewhere. These remain reviewer obligations: the tool does not mechanically prove source correctness or infer test execution. The essential assembly/capture/persistence code for this claim is within the already associated review.rs; no additional production association is needed.

All five ordinary tests contain meaningful visible assertions. initial_context_preserves_instructions_and_exact_uniform_fragments compares the complete claim, whole implementation file, exact annotated test source, prompt, coordinator instructions and persisted input. input_keeps_complete_association_metadata_and_appends_context_in_one_collection checks crate/target/module/file/inherited cfg/excerpt/region/status/explanation and confirms captured extra context appends without changing initial fragments or metadata. region_association_preserves_placeholder_explanation_and_excerpt checks nested TODO module identity, true region, exact explanatory content and saved association equality. accepted_placeholder_reports_preserve_todo_and_na_evidence checks both TODO and N/A classifications/explanations and verifies acceptance leaves zero ordinary approvals and the appropriate placeholder count. Its synthetic backend prerequisite/editorial rationale and the region fixture's numeric-model prerequisite test preservation, not actual deferred behavior of this anchor. implementation_metadata_is_sorted_and_excludes_source_positions checks reverse traversal becomes module-sorted metadata, exact nine serialized keys, and metadata equality after source reordering/leading context changes while whole-file fragments differ. This directly detects accidental positions or traversal-order dependence.

There are no TODO or N/A associations for this anchor. The complete claim, including dependency capture and source-judgment versus execution distinction, is accounted for; the two association-only changes introduce no new gaps. This followup executed review start/read and capture comparisons, followed by record, but no tests, formatting, source edits or workspace build. The previous review's focused test result is historical evidence, not a command executed here. No requested edits.

Browse meta anchors

116 anchors

Specification anchors and declared coverage
AnchorImplementationTests
meta (116)102 Implemented24 TODO103 Implemented36 TODO
meta.anchors (22)22 Implemented21 Implemented12 TODO
anchor_pagesImplementedImplementedTODO
book_explorerImplementedImplementedTODO
canonical_sourcesImplementedImplementedTODO
meta.anchors.content (7)7 Implemented7 Implemented
blocksImplementedImplemented
explicit_endImplementedImplemented
headingImplementedImplemented
literal_syntaxImplementedImplemented
next_anchorImplementedImplemented
source_endImplementedImplemented
unmatched_endImplementedImplemented
context_navigationImplementedImplementedTODO
evidence_statusImplementedImplementedTODO
explorer_navigationImplementedTODO
implementation_coverageImplementedImplementedTODO
implementation_referencesImplementedImplementedTODO
placeholder_statusImplementedImplementedTODO
point_excerptsImplementedImplementedTODO
region_balanceImplementedImplemented
region_excerptsImplementedImplementedTODO
test_coverageImplementedImplemented
test_referencesImplementedImplemented
unique_namesImplementedImplementedTODO
meta.book (21)10 Implemented18 TODO12 Implemented18 TODO
anchor_movesImplementedTODOImplementedTODO
authorityImplementedTODOImplementedTODO
browser_deliveryTODOImplementedTODO
browser_dependenciesTODOTODO
browser_rust_sourceTODOTODO
browser_searchTODOTODO
browser_serveTODOTODO
browser_structureTODOTODO
chapter_namesImplementedTODOImplementedTODO
crate_ownershipImplementedImplemented
crates_landingImplementedImplemented
entity_linksTODOTODO
index_groupsImplementedTODOImplementedTODO
index_namespace_pagesImplementedImplemented
index_rowsImplementedTODOImplementedTODO
index_statusImplementedTODOImplementedTODO
rfd_changesTODOTODO
sage_chaptersTODOImplementedTODO
self_descriptionTODOTODO
shared_modelImplementedTODOImplementedTODO
source_rolesTODOTODO
meta.contracts (4)4 Implemented3 TODO4 Implemented3 TODO
cache_invocationsImplementedTODOImplementedTODO
correspondenceImplementedImplemented
observation_coverageImplementedTODOImplementedTODO
validated_sessionImplementedTODOImplementedTODO
meta.language (39)39 Implemented39 Implemented
meta.language.calls (2)2 Implemented2 Implemented
declaredImplementedImplemented
forbiddenImplementedImplemented
meta.language.classes (3)3 Implemented3 Implemented
abstract_completeImplementedImplemented
override_signatureImplementedImplemented
single_inheritanceImplementedImplemented
meta.language.contexts (1)1 Implemented1 Implemented
inheritanceImplementedImplemented
meta.language.envelopes (7)7 Implemented7 Implemented
class_callsImplementedImplemented
createsImplementedImplemented
direct_callsImplementedImplemented
leafImplementedImplemented
permissionsImplementedImplemented
readsImplementedImplemented
receiver_callsImplementedImplemented
meta.language.fields (2)2 Implemented2 Implemented
context_stateImplementedImplemented
kindsImplementedImplemented
meta.language.methods (2)2 Implemented2 Implemented
kindsImplementedImplemented
proseImplementedImplemented
meta.language.model (3)3 Implemented3 Implemented
forbidden_pathsImplementedImplemented
inherited_prohibitionsImplementedImplemented
virtual_dispatchImplementedImplemented
meta.language.types (19)19 Implemented19 Implemented
argument_arityImplementedImplemented
declaration_proseImplementedImplemented
enum_variantsImplementedImplemented
field_proseImplementedImplemented
generic_parametersImplementedImplemented
member_commasImplementedImplemented
name_resolutionImplementedImplemented
opaque_representationImplementedImplemented
preludeImplementedImplemented
qualified_namesImplementedImplemented
recursive_valuesImplementedImplemented
struct_fieldsImplementedImplemented
tuplesImplementedImplemented
type_expressionsImplementedImplemented
unique_fieldsImplementedImplemented
unique_parametersImplementedImplemented
unique_variantsImplementedImplemented
unknown_namesImplementedImplemented
variant_proseImplementedImplemented
meta.reviews (27)27 Implemented27 Implemented
claim_textImplementedImplemented
complete_test_setImplementedImplemented
decisionsImplementedImplemented
fragment_associationsImplementedImplemented
fragment_formatImplementedImplemented
fragment_freshnessImplementedImplemented
gateImplementedImplemented
input_formatImplementedImplemented
input_fragmentsImplementedImplemented
output_formatImplementedImplemented
preparationImplementedImplemented
record_requiredImplementedImplemented
recorded_readsImplementedImplemented
recordingImplementedImplemented
review_delegationImplementedImplemented
review_diagnosticsImplementedImplemented
review_instructionsImplementedImplemented
review_scopeImplementedImplemented
selector_claimImplementedImplemented
selector_line_rangeImplementedImplemented
selector_testImplementedImplemented
selector_whole_fileImplementedImplemented
source_representationImplementedImplemented
stalenessImplementedImplemented
summary_formatImplementedImplemented
test_sourceImplementedImplemented
validation_layoutImplementedImplemented
meta.validation (3)3 TODO3 TODO
claim_specific_evidenceTODOTODO
independent_inspectionTODOTODO
review_packetsTODOTODO