meta.book.browser_search

Search finds declared entities by name, qualified model path, descriptive prose, and corresponding Rust paths when available. Crate and entity-kind filters combine with the search text. Results identify each entity’s kind and owner and link directly to it, including named members. The view states when no entities match. Changing search or filters does not invalidate an entity’s direct link or prevent opening a linked entity outside the current results.

Read in specification context · design/meta/book.md

Implementation

TODO crates/sage-meta/tests/spec_plan.rs:153–160

sage_meta::todo · test:spec_plan

TODO: Cover named members, prose, model/Rust paths, combined filters, empty results, and links to entities outside the active search results.

#![allow(unused)]
fn main() {
    // {anchor}`meta.book.browser_search`<<
    #[test]
    #[sage::test(meta.book.browser_search)]
    fn browser_searches_entities_and_combines_filters() {
        // TODO: Cover named members, prose, model/Rust paths, combined filters,
        // empty results, and links to entities outside the active search results.
    }
    // >>

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

TODO sage_meta::todo::browser_searches_entities_and_combines_filters

crates/sage-meta/tests/spec_plan.rs · test:spec_plan

#![allow(unused)]
fn main() {
#[test]
    #[sage::test(meta.book.browser_search)]
    fn browser_searches_entities_and_combines_filters() {
        // TODO: Cover named members, prose, model/Rust paths, combined filters,
        // empty results, and links to entities outside the active search results.
    }
}

See more source ↗

Review: Accepted · final_quality.

Reviewed meta.book.browser_search's complete claim and all associated evidence. The sole implementation association and sole test association are the explicit todo::browser_searches_entities_and_combines_filters region in spec_plan.rs. Its body is only a TODO comment and contains no behavioral assertions; the anchor remains deferred rather than implemented or tested. No N/A or ordinary evidence is associated. No behavior tests were executed in this review.

The complete obligation includes matching names, qualified model paths, descriptive prose and available corresponding Rust paths; combining text with crate and kind filters; identifying result kinds and owners; direct entity links including named members; an explicit no-results state; and stable/openable links even when current filtering excludes the target. The TODO explicitly names members, prose, model/Rust paths, combined filters, empty results and opening entities outside active results. The unmentioned-by-name basic name matching and result identity are part of that same search-result fixture prerequisite, not independently established coverage.

I captured and inspected web/browser.js to assess existing components and the concrete deferral. buildModel retains crate/module/item/method/member maps with qualified keys and owner/kind metadata, including fields and variants. searchModel lowercases and trims the query and combines crate/kind predicates with matching against keys, descriptions and available Rust target paths. navigation groups matching entities, emits owner-qualified labels for members/methods, kind labels and entityRoute links, and displays a No matches message when no result markup exists. Rendering resolves routes against the complete model rather than the filtered result array; search/filter listeners update navigation while direct hash navigation invokes the renderer independently. These source paths suggest the intended structure but are not a replacement for associated meaningful test assertions.

Replacing this TODO requires a fixture with multiple crates and entity kinds, methods and named members, overlapping names, distinctive prose and optional Rust correspondences. Tests must assert exact result sets for each search field and combined filters, result owner/kind labels and target routes, empty-result messaging, and opening a direct link whose target is excluded before and after filter changes. Browser interaction checks should exercise both standalone and embedded navigation where relevant. Until that evidence exists, current implementation completeness and interaction correctness are not established by this report. The explicit TODO honestly defers the complete search behavior matrix, so no source change or additional requested edit is necessary for this review.

Browse meta anchors

116 anchors

Specification anchors and declared coverage
AnchorImplementationTests
meta (116)102 Implemented24 TODO103 Implemented36 TODO
meta.anchors (22)22 Implemented21 Implemented12 TODO
anchor_pagesImplementedImplementedTODO
book_explorerImplementedImplementedTODO
canonical_sourcesImplementedImplementedTODO
meta.anchors.content (7)7 Implemented7 Implemented
blocksImplementedImplemented
explicit_endImplementedImplemented
headingImplementedImplemented
literal_syntaxImplementedImplemented
next_anchorImplementedImplemented
source_endImplementedImplemented
unmatched_endImplementedImplemented
context_navigationImplementedImplementedTODO
evidence_statusImplementedImplementedTODO
explorer_navigationImplementedTODO
implementation_coverageImplementedImplementedTODO
implementation_referencesImplementedImplementedTODO
placeholder_statusImplementedImplementedTODO
point_excerptsImplementedImplementedTODO
region_balanceImplementedImplemented
region_excerptsImplementedImplementedTODO
test_coverageImplementedImplemented
test_referencesImplementedImplemented
unique_namesImplementedImplementedTODO
meta.book (21)10 Implemented18 TODO12 Implemented18 TODO
anchor_movesImplementedTODOImplementedTODO
authorityImplementedTODOImplementedTODO
browser_deliveryTODOImplementedTODO
browser_dependenciesTODOTODO
browser_rust_sourceTODOTODO
browser_searchTODOTODO
browser_serveTODOTODO
browser_structureTODOTODO
chapter_namesImplementedTODOImplementedTODO
crate_ownershipImplementedImplemented
crates_landingImplementedImplemented
entity_linksTODOTODO
index_groupsImplementedTODOImplementedTODO
index_namespace_pagesImplementedImplemented
index_rowsImplementedTODOImplementedTODO
index_statusImplementedTODOImplementedTODO
rfd_changesTODOTODO
sage_chaptersTODOImplementedTODO
self_descriptionTODOTODO
shared_modelImplementedTODOImplementedTODO
source_rolesTODOTODO
meta.contracts (4)4 Implemented3 TODO4 Implemented3 TODO
cache_invocationsImplementedTODOImplementedTODO
correspondenceImplementedImplemented
observation_coverageImplementedTODOImplementedTODO
validated_sessionImplementedTODOImplementedTODO
meta.language (39)39 Implemented39 Implemented
meta.language.calls (2)2 Implemented2 Implemented
declaredImplementedImplemented
forbiddenImplementedImplemented
meta.language.classes (3)3 Implemented3 Implemented
abstract_completeImplementedImplemented
override_signatureImplementedImplemented
single_inheritanceImplementedImplemented
meta.language.contexts (1)1 Implemented1 Implemented
inheritanceImplementedImplemented
meta.language.envelopes (7)7 Implemented7 Implemented
class_callsImplementedImplemented
createsImplementedImplemented
direct_callsImplementedImplemented
leafImplementedImplemented
permissionsImplementedImplemented
readsImplementedImplemented
receiver_callsImplementedImplemented
meta.language.fields (2)2 Implemented2 Implemented
context_stateImplementedImplemented
kindsImplementedImplemented
meta.language.methods (2)2 Implemented2 Implemented
kindsImplementedImplemented
proseImplementedImplemented
meta.language.model (3)3 Implemented3 Implemented
forbidden_pathsImplementedImplemented
inherited_prohibitionsImplementedImplemented
virtual_dispatchImplementedImplemented
meta.language.types (19)19 Implemented19 Implemented
argument_arityImplementedImplemented
declaration_proseImplementedImplemented
enum_variantsImplementedImplemented
field_proseImplementedImplemented
generic_parametersImplementedImplemented
member_commasImplementedImplemented
name_resolutionImplementedImplemented
opaque_representationImplementedImplemented
preludeImplementedImplemented
qualified_namesImplementedImplemented
recursive_valuesImplementedImplemented
struct_fieldsImplementedImplemented
tuplesImplementedImplemented
type_expressionsImplementedImplemented
unique_fieldsImplementedImplemented
unique_parametersImplementedImplemented
unique_variantsImplementedImplemented
unknown_namesImplementedImplemented
variant_proseImplementedImplemented
meta.reviews (27)27 Implemented27 Implemented
claim_textImplementedImplemented
complete_test_setImplementedImplemented
decisionsImplementedImplemented
fragment_associationsImplementedImplemented
fragment_formatImplementedImplemented
fragment_freshnessImplementedImplemented
gateImplementedImplemented
input_formatImplementedImplemented
input_fragmentsImplementedImplemented
output_formatImplementedImplemented
preparationImplementedImplemented
record_requiredImplementedImplemented
recorded_readsImplementedImplemented
recordingImplementedImplemented
review_delegationImplementedImplemented
review_diagnosticsImplementedImplemented
review_instructionsImplementedImplemented
review_scopeImplementedImplemented
selector_claimImplementedImplemented
selector_line_rangeImplementedImplemented
selector_testImplementedImplemented
selector_whole_fileImplementedImplemented
source_representationImplementedImplemented
stalenessImplementedImplemented
summary_formatImplementedImplemented
test_sourceImplementedImplemented
validation_layoutImplementedImplemented
meta.validation (3)3 TODO3 TODO
claim_specific_evidenceTODOTODO
independent_inspectionTODOTODO
review_packetsTODOTODO