crates.sage_ir.metadata.keyed_reuse

Raw and lowered metadata share the same narrow reuse key. Each lowered semantic fact observes only its corresponding owned provider fact. Repeating an unchanged request reuses the lowered value without another raw request, and changing an unrelated provider fact does not invalidate it.

Read in specification context · design/crates/sage_ir/metadata.sage

Implementation

Implemented crates/sage-ir/src/external_syms.rs:26–31

sage_ir::external_syms · lib:sage_ir

#![allow(unused)]
fn main() {
// {anchor}`crates.sage_ir.metadata.keyed_reuse`
pub fn external_trait_signature<'db>(
    db: &'db dyn crate::Db,
    trait_sym: SymExt<'db>,
) -> Option<Stashed<TraitSignature<'db>>> {
    let raw = db

}

See more source ↗

TODO crates/sage-ir/src/external_syms.rs:844–854

sage_ir::external_syms::todo · lib:sage_ir

TODO: Add independently tracked, definition/product-keyed owned provider inputs and connect each lowered query to its corresponding input. The current immutable TcxDb service has no per-fact update/invalidation layer; Salsa memoizes lowering but does not track changes to provider facts. Associated-value facts must also own the binder information needed for lowering: lower_associated_type_value currently loads the impl signature separately. Completing that provider representation is prerequisite to the cold/warm and relevant/unrelated provider-edit verification matrix.

#![allow(unused)]
fn main() {
    // {anchor}`crates.sage_ir.metadata.keyed_reuse`<<
    // TODO: Add independently tracked, definition/product-keyed owned provider
    // inputs and connect each lowered query to its corresponding input. The
    // current immutable TcxDb service has no per-fact update/invalidation layer;
    // Salsa memoizes lowering but does not track changes to provider facts.
    // Associated-value facts must also own the binder information needed for
    // lowering: lower_associated_type_value currently loads the impl signature
    // separately. Completing that provider representation is prerequisite to
    // the cold/warm and relevant/unrelated provider-edit verification matrix.
    mod provider_fact_reuse {}
    // >>

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

TODO sage_meta::todo::metadata_keyed_reuse

crates/sage-meta/tests/semantic_spec.rs · test:semantic_spec

#![allow(unused)]
fn main() {
#[test]
    #[sage::test(crates.sage_ir.metadata.keyed_reuse)]
    fn metadata_keyed_reuse() {
        // TODO: Complete the claim-specific verification matrix:
        // Cold/warm traces pair every lowered query with its exact raw operation; the warm trace contains
        // neither execution, relevant edits invalidate both layers, and unrelated-key edits preserve or
        // backdate the lowered result.
    }
}

See more source ↗

Review: Accepted · Codex /root/anchor_094.

Reviewed the complete keyed_reuse claim, ordinary external_trait_signature association, explicit provider_fact_reuse TODO implementation region, and sole metadata_keyed_reuse TODO test. Captured the metadata design and accepted provider-fact RFD. Source inspection only; no test execution or source changes.

The claim requires each lowered fact to observe only its corresponding owned provider fact, unchanged requests to reuse lowered values without new raw requests, and unrelated provider changes not to invalidate that value. The ordinary implementation is a Salsa-tracked external_trait_signature query keyed by SymExt, requesting the raw trait signature via crate number/definition index and lowering it into owned semantic storage. Neighboring tracked queries similarly separate products and associated-value requests carry impl and associated-definition identities. This is current lowering-level memoization, not an implemented independently tracked provider-input layer.

The explicit TODO accurately identifies the missing prerequisite: definition/product-keyed owned provider inputs with per-fact invalidation wired into each lowered query. It also records a concrete remaining dependency mismatch visible in the same source: lower_associated_type_value fetches external_impl_signature to obtain binder generics in addition to its raw associated-value input. A self-contained associated-value provider fact must supply the necessary binder information before the one-corresponding-fact requirement is fulfilled. I do not interpret current immutable-service memoization as proof of relevant/unrelated provider-edit behavior or silently accept that extra fact as satisfying the complete claim.

The metadata_keyed_reuse test is TODO and contains no assertions. It requires cold/warm query-to-raw-operation pairing, no repeat execution on warm requests, relevant edit invalidation and unrelated-key preservation/backdating. Completing the provider representation and associated binder ownership is explicitly prerequisite to that verification matrix. The RFD's narrow provider fact boundary supports that destination but is not runtime evidence. Both implementation entries and the test are accounted for; current partial memoization and the full missing provider/update behavior remain distinguished. The documented implementation and evidence deferrals are honest and concrete, so no additional edits are requested.

Browse crates anchors

139 anchors

Specification anchors and declared coverage
AnchorImplementationTests
crates (139)114 Implemented37 TODO2 N/A74 Implemented107 TODO
crates.sage_inspector (15)13 Implemented1 TODO2 N/A3 Implemented15 TODO
crates.sage_inspector.inspection (15)13 Implemented1 TODO2 N/A3 Implemented15 TODO
balanced_tracesImplementedTODO
canonical_ownershipImplementedImplementedTODO
derive_reflectionImplementedImplementedTODO
detail_free_indexImplementedTODO
deterministic_traceImplementedTODO
durable_navigationN/ATODO
generic_browserN/ATODO
owned_reflectionImplementedImplementedTODO
product_availabilityImplementedTODO
revision_and_demandImplementedTODO
semantic_phase_boundaryImplementedTODO
source_evidenceImplementedTODO
typed_serviceImplementedTODO
unknown_workImplementedTODOTODO
workspace_actorImplementedTODO
crates.sage_ir (90)67 Implemented34 TODO40 Implemented88 TODO
crates.sage_ir.checking (12)12 Implemented3 TODO5 Implemented12 TODO
crates.sage_ir.checking.body (5)5 Implemented2 TODO3 Implemented5 TODO
elaborationImplementedImplementedTODO
expected_typesImplementedTODOTODO
interface_dependenciesImplementedImplementedTODO
isolated_completionImplementedImplementedTODO
operator_callsImplementedTODOTODO
identity_mintingImplementedTODO
owned_productsImplementedImplementedTODO
crates.sage_ir.checking.signature (4)4 Implemented1 TODO1 Implemented4 TODO
body_independenceImplementedTODO
narrow_detailImplementedTODOTODO
owner_binderImplementedImplementedTODO
storageImplementedTODO
symbol_keyed_interfacesImplementedTODO
crates.sage_ir.crate (9)9 TODO9 TODO
explicit_restrictionsTODOTODO
identity_before_detailTODOTODO
incremental_evidenceTODOTODO
narrow_demandsTODOTODO
reexecution_and_invalidationTODOTODO
represented_completenessTODOTODO
restrictions_and_gapsTODOTODO
semantic_query_boundariesTODOTODO
terminal_incompletenessTODOTODO
crates.sage_ir.inference (8)8 Implemented6 Implemented8 TODO
atomic_checkingImplementedImplementedTODO
body_local_quiescenceImplementedImplementedTODO
canonical_boundaryImplementedImplementedTODO
completed_body_boundaryImplementedTODO
numeric_domainsImplementedImplementedTODO
subtyping_and_coercionImplementedImplementedTODO
terminal_obligationsImplementedTODO
transaction_isolationImplementedImplementedTODO
crates.sage_ir.metadata (4)4 Implemented1 TODO4 TODO
explicit_incompletenessImplementedTODO
keyed_reuseImplementedTODOTODO
product_boundariesImplementedTODO
provider_authorityImplementedTODO
crates.sage_ir.modules (8)7 Implemented1 TODO4 Implemented8 TODO
crates.sage_ir.modules.expand (4)4 Implemented2 Implemented4 TODO
completenessImplementedImplementedTODO
dependenciesImplementedTODO
direct_membersImplementedTODO
recursion_and_fixpointImplementedImplementedTODO
crates.sage_ir.modules.parse (4)3 Implemented1 TODO2 Implemented4 TODO
dependenciesImplementedTODO
detail_firewallImplementedImplementedTODO
recovery_completenessTODOTODO
syntax_identitiesImplementedImplementedTODO
crates.sage_ir.resolution (5)5 Implemented1 TODO3 Implemented4 TODO
crates.sage_ir.resolution.lookup (5)5 Implemented1 TODO3 Implemented4 TODO
completenessImplementedTODOImplementedTODO
dependenciesImplementedTODO
expansion_import_ambiguityImplementedImplemented
identity_onlyImplementedTODO
precedenceImplementedImplementedTODO
crates.sage_ir.solver (9)7 Implemented7 TODO5 Implemented9 TODO
alternative_isolationImplementedTODOImplementedTODO
bounded_completenessImplementedTODOTODO
candidate_completenessImplementedTODO
canonical_cyclesTODOTODO
canonical_outputsImplementedImplementedTODO
local_index_firewallTODOTODO
normalization_demandImplementedTODOImplementedTODO
schedule_independenceImplementedTODOImplementedTODO
shared_final_resultImplementedTODOImplementedTODO
crates.sage_ir.symbols (8)8 Implemented4 Implemented7 TODO
associated_identityImplementedImplemented
associated_interfacesImplementedTODO
body_interfacesImplementedImplementedTODO
definition_identityImplementedTODO
external_fact_queriesImplementedTODO
external_identityImplementedTODO
kind_wrappersImplementedImplementedTODO
local_identityImplementedImplementedTODO
crates.sage_ir.types (27)16 Implemented12 TODO13 Implemented27 TODO
crates.sage_ir.types.aliases (2)1 Implemented1 TODO1 Implemented2 TODO
identityImplementedImplementedTODO
revelationTODOTODO
crates.sage_ir.types.binder (1)1 Implemented1 TODO1 Implemented1 TODO
owner_parametersImplementedTODOImplementedTODO
crates.sage_ir.types.body (13)4 Implemented9 TODO3 Implemented13 TODO
awaitTODOTODO
closuresTODOTODO
conditional_patternsTODOTODO
coroutinesTODOTODO
diagnosed_recoveryImplementedImplementedTODO
elaboratedTODOImplementedTODO
for_iterationTODOTODO
indexingTODOTODO
macro_expansionTODOTODO
no_inferenceImplementedImplementedTODO
resolved_referencesImplementedTODO
try_residualTODOTODO
typed_provenanceImplementedTODO
crates.sage_ir.types.calls (2)1 Implemented1 TODO1 Implemented2 TODO
dispatch_familiesTODOTODO
selected_semanticsImplementedImplementedTODO
crates.sage_ir.types.lifetimes (2)2 Implemented2 Implemented2 TODO
dummyImplementedImplementedTODO
unchecked_borrowsImplementedImplementedTODO
crates.sage_ir.types.operators (2)2 Implemented1 Implemented2 TODO
lazy_control_flowImplementedTODO
trait_callsImplementedImplementedTODO
scoped_identitiesImplementedTODO
crates.sage_ir.types.spans (4)4 Implemented4 Implemented4 TODO
generated_identityImplementedImplementedTODO
item_originImplementedImplementedTODO
offset_reuseImplementedImplementedTODO
relative_compositionImplementedImplementedTODO
crates.sage_oracle_harness (4)4 Implemented2 TODO1 Implemented4 TODO
crates.sage_oracle_harness.crate (4)4 Implemented2 TODO1 Implemented4 TODO
deterministic_emissionImplementedTODO
exact_comparisonImplementedTODOImplementedTODO
fixed_projectionImplementedTODO
independent_coverageImplementedTODOTODO
crates.sage_stash (5)5 Implemented5 Implemented
crates.sage_stash.storage (5)5 Implemented5 Implemented
handle_ownershipImplementedImplemented
immutable_entriesImplementedImplemented
query_valueImplementedImplemented
rooted_equalityImplementedImplemented
typed_interningImplementedImplemented
crates.sage_test_harness (25)25 Implemented25 Implemented
crates.sage_test_harness.compile_tests (25)25 Implemented25 Implemented
annotation_validationImplementedImplemented
blessing_gateImplementedImplemented
callsite_updatesImplementedImplemented
checking_scopeImplementedImplemented
compiler_conditionsImplementedImplemented
completed_typesImplementedImplemented
coordinatesImplementedImplemented
dependenciesImplementedImplemented
diagnostic_countsImplementedImplemented
diagnostic_locationsImplementedImplemented
editionImplementedImplemented
fixturesImplementedImplemented
grouped_observationsImplementedImplemented
invocationImplementedImplemented
production_executionImplementedImplemented
project_isolationImplementedImplemented
query_captureImplementedImplemented
query_projectionImplementedImplemented
renderingImplementedImplemented
resolved_symbolsImplementedImplemented
review_visibilityImplementedImplemented
rustc_executionImplementedImplemented
rustc_lintsImplementedImplemented
starting_expressionsImplementedImplemented
target_lineImplementedImplemented