meta.book.rfd_changes

An RFD branch contains both the design record and the proposed normative Design changes. The RFD records motivation, alternatives, goals, and a high-level overview of the required changes, with links to the affected Design pages and anchors. Its implementation plan develops that overview into stages. Acceptance merges the record and specification changes together; unfinished implementation or tests remain explicit TODO entries. Subsequent implementation replaces those entries with code and evidence. Completing an RFD does not require copying its rules into Design, because the normative changes were already expressed there.

Read in specification context · design/meta/book.md

Implementation

TODO crates/sage-meta/tests/spec_plan.rs:252–259

sage_meta::todo · test:spec_plan

TODO: Verify RFD guidance/template links to the same-branch Design diff and records pending implementation without later rule promotion.

#![allow(unused)]
fn main() {
    // {anchor}`meta.book.rfd_changes`<<
    #[test]
    #[sage::test(meta.book.rfd_changes)]
    fn rfd_branches_include_the_design_changes() {
        // TODO: Verify RFD guidance/template links to the same-branch Design diff
        // and records pending implementation without later rule promotion.
    }
    // >>

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

TODO sage_meta::todo::rfd_branches_include_the_design_changes

crates/sage-meta/tests/spec_plan.rs · test:spec_plan

#![allow(unused)]
fn main() {
#[test]
    #[sage::test(meta.book.rfd_changes)]
    fn rfd_branches_include_the_design_changes() {
        // TODO: Verify RFD guidance/template links to the same-branch Design diff
        // and records pending implementation without later rule promotion.
    }
}

See more source ↗

Review: Accepted · final_quality.

Reviewed the complete meta.book.rfd_changes claim and its entire associated evidence. Both implementation and test associations point to the explicit todo::rfd_branches_include_the_design_changes region in spec_plan.rs. The function contains no assertions, only its TODO; it must remain deferred and is not evidence that repository branches or acceptance operations satisfy the workflow. No ordinary or N/A entries are associated. No behavior tests were executed.

The claim requires an RFD branch to carry the record and proposed normative Design changes together; motivation, alternatives, goals and a linked high-level overview; a staged implementation plan; acceptance of record and specification together; explicit TODO evidence for unfinished code/tests; subsequent replacement by implementation/evidence; and no delayed copying of normative rules into Design on completion. The existing TODO calls for verifying guidance/template links to the same-branch Design diff and pending implementation without later rule promotion, which is an honest deferral of this lifecycle check.

I captured the RFD guidance, README template, implementation-plan template and maintaining-the-docs guidance. The RFD guide instructs opening one branch/PR with both the RFD and corresponding Design changes, locating testable requirements in Design, linking rationale and steps to affected pages/anchors, and doing implementation PRs after acceptance. The README template requests motivation, high-level changes, links to each normative change, rationale/alternatives and an implementation-plan pointer; its specification-change instructions say not to wait for implementation completion to write normative paragraphs. The plan template asks for independently mergeable stages with Design anchors and verification, and explicitly says the proposal already contains the normative diff while implementation replaces placeholders. The authoring guidance reinforces same-change specification/code/test/review updates and generated TODO evidence. These are documentary workflow components, not an automated assertion that every actual branch follows them.

Replacing the placeholder requires concrete validation of the guidance/template contract and a representative proposed-to-accepted-to-implemented change fixture: verify record/Design coexistence and direct page/anchor links; required motivation/goals/alternatives/overview and staged plan; retained TODO implementation/test entries while unfinished; and replacement with substantive evidence without a second normative-rule promotion. Branch/merge properties require an explicit repository-history or review-process check rather than inference from a passing empty Rust function. All requirements remain accounted for as explicitly deferred. No implementation-completeness or lifecycle-execution claim is made, and no source edit or additional requested edit is necessary for this review.

Browse meta anchors

116 anchors

Specification anchors and declared coverage
AnchorImplementationTests
meta (116)102 Implemented24 TODO103 Implemented36 TODO
meta.anchors (22)22 Implemented21 Implemented12 TODO
anchor_pagesImplementedImplementedTODO
book_explorerImplementedImplementedTODO
canonical_sourcesImplementedImplementedTODO
meta.anchors.content (7)7 Implemented7 Implemented
blocksImplementedImplemented
explicit_endImplementedImplemented
headingImplementedImplemented
literal_syntaxImplementedImplemented
next_anchorImplementedImplemented
source_endImplementedImplemented
unmatched_endImplementedImplemented
context_navigationImplementedImplementedTODO
evidence_statusImplementedImplementedTODO
explorer_navigationImplementedTODO
implementation_coverageImplementedImplementedTODO
implementation_referencesImplementedImplementedTODO
placeholder_statusImplementedImplementedTODO
point_excerptsImplementedImplementedTODO
region_balanceImplementedImplemented
region_excerptsImplementedImplementedTODO
test_coverageImplementedImplemented
test_referencesImplementedImplemented
unique_namesImplementedImplementedTODO
meta.book (21)10 Implemented18 TODO12 Implemented18 TODO
anchor_movesImplementedTODOImplementedTODO
authorityImplementedTODOImplementedTODO
browser_deliveryTODOImplementedTODO
browser_dependenciesTODOTODO
browser_rust_sourceTODOTODO
browser_searchTODOTODO
browser_serveTODOTODO
browser_structureTODOTODO
chapter_namesImplementedTODOImplementedTODO
crate_ownershipImplementedImplemented
crates_landingImplementedImplemented
entity_linksTODOTODO
index_groupsImplementedTODOImplementedTODO
index_namespace_pagesImplementedImplemented
index_rowsImplementedTODOImplementedTODO
index_statusImplementedTODOImplementedTODO
rfd_changesTODOTODO
sage_chaptersTODOImplementedTODO
self_descriptionTODOTODO
shared_modelImplementedTODOImplementedTODO
source_rolesTODOTODO
meta.contracts (4)4 Implemented3 TODO4 Implemented3 TODO
cache_invocationsImplementedTODOImplementedTODO
correspondenceImplementedImplemented
observation_coverageImplementedTODOImplementedTODO
validated_sessionImplementedTODOImplementedTODO
meta.language (39)39 Implemented39 Implemented
meta.language.calls (2)2 Implemented2 Implemented
declaredImplementedImplemented
forbiddenImplementedImplemented
meta.language.classes (3)3 Implemented3 Implemented
abstract_completeImplementedImplemented
override_signatureImplementedImplemented
single_inheritanceImplementedImplemented
meta.language.contexts (1)1 Implemented1 Implemented
inheritanceImplementedImplemented
meta.language.envelopes (7)7 Implemented7 Implemented
class_callsImplementedImplemented
createsImplementedImplemented
direct_callsImplementedImplemented
leafImplementedImplemented
permissionsImplementedImplemented
readsImplementedImplemented
receiver_callsImplementedImplemented
meta.language.fields (2)2 Implemented2 Implemented
context_stateImplementedImplemented
kindsImplementedImplemented
meta.language.methods (2)2 Implemented2 Implemented
kindsImplementedImplemented
proseImplementedImplemented
meta.language.model (3)3 Implemented3 Implemented
forbidden_pathsImplementedImplemented
inherited_prohibitionsImplementedImplemented
virtual_dispatchImplementedImplemented
meta.language.types (19)19 Implemented19 Implemented
argument_arityImplementedImplemented
declaration_proseImplementedImplemented
enum_variantsImplementedImplemented
field_proseImplementedImplemented
generic_parametersImplementedImplemented
member_commasImplementedImplemented
name_resolutionImplementedImplemented
opaque_representationImplementedImplemented
preludeImplementedImplemented
qualified_namesImplementedImplemented
recursive_valuesImplementedImplemented
struct_fieldsImplementedImplemented
tuplesImplementedImplemented
type_expressionsImplementedImplemented
unique_fieldsImplementedImplemented
unique_parametersImplementedImplemented
unique_variantsImplementedImplemented
unknown_namesImplementedImplemented
variant_proseImplementedImplemented
meta.reviews (27)27 Implemented27 Implemented
claim_textImplementedImplemented
complete_test_setImplementedImplemented
decisionsImplementedImplemented
fragment_associationsImplementedImplemented
fragment_formatImplementedImplemented
fragment_freshnessImplementedImplemented
gateImplementedImplemented
input_formatImplementedImplemented
input_fragmentsImplementedImplemented
output_formatImplementedImplemented
preparationImplementedImplemented
record_requiredImplementedImplemented
recorded_readsImplementedImplemented
recordingImplementedImplemented
review_delegationImplementedImplemented
review_diagnosticsImplementedImplemented
review_instructionsImplementedImplemented
review_scopeImplementedImplemented
selector_claimImplementedImplemented
selector_line_rangeImplementedImplemented
selector_testImplementedImplemented
selector_whole_fileImplementedImplemented
source_representationImplementedImplemented
stalenessImplementedImplemented
summary_formatImplementedImplemented
test_sourceImplementedImplemented
validation_layoutImplementedImplemented
meta.validation (3)3 TODO3 TODO
claim_specific_evidenceTODOTODO
independent_inspectionTODOTODO
review_packetsTODOTODO