meta.language.classes.override_signature

An overriding method must preserve the inherited method’s operation kind and resolved result type.

Read in specification context · design/meta/language.md

Implementation

Implemented crates/sage-meta/src/validate.rs:468–473

sage_meta::validate · lib:sage_meta

#![allow(unused)]
fn main() {
                    // {anchor}`meta.language.classes.override_signature`
                    if base_method.kind != method.kind
                        || self.resolve_type(&base_entry.namespace, &[], &base_method.result)
                            != self.resolve_type(&entry.namespace, &[], &method.result)
                    {
                        report(

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

Implemented sage_meta::checks_nested_arguments_in_fields_results_and_overrides

crates/sage-meta/tests/language.rs · test:language

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.language.classes.override_signature)]
fn checks_nested_arguments_in_fields_results_and_overrides() {
    let errors = check(
        r#"
        class Base { """Base."""
            fn value() -> Vec<Value> { """Get.""" envelope {} }
        }
        class Child extends crate::Base { """Child."""
            input broken: Option<Missing>;
            override fn value() -> Vec<Option<Value>> { """Get.""" envelope {} }
            fn missing() -> Option<Unknown> { """Get.""" envelope {} }
        }
    "#,
    );
    assert!(
        errors
            .iter()
            .any(|e| e.message.contains("unknown type Missing"))
    );
    assert!(
        errors
            .iter()
            .any(|e| e.message.contains("unknown type Unknown"))
    );
    assert!(
        errors
            .iter()
            .any(|e| e.message.contains("preserve method kind and result type"))
    );
    assert!(
        check(
            r#"
        class Base { """Base.""" fn value() -> Vec<Value> { """Get.""" envelope {} } }
        class Child extends crate::Base { """Child."""
            override fn value() -> Vec<crate::Value> { """Get.""" envelope {} }
        }
    "#
        )
        .is_empty()
    );
    let errors = check(
        r#"
        class Base { """Base.""" fn value() -> Value { """Get.""" envelope {} } }
        class Child extends crate::Base { """Child."""
            override query value() -> Value { """Get.""" envelope {} }
        }
    "#,
    );
    assert!(errors.iter().any(|error| {
        error
            .message
            .contains("preserve method kind and result type")
    }));
}
}

See more source ↗

Review: Accepted · Codex /root/anchor_190.

Source review: the complete claim requires preserving both operation kind and resolved result type for an override. The single ordinary implementation association in validate.rs checks the selected inherited method via base/method/ancestors, compares MethodKind and resolve_type results in the respective declaring namespaces, and emits the signature diagnostic on either difference. Recursive canonicalization includes tuple structure and named type arguments, so differing spellings of the same type are accepted while nested differences are rejected; unresolved result types independently produce errors. The single ordinary associated test checks a nested Vec<Value> versus Vec<Option<Value>> mismatch, separately asserts unknown field/result diagnostics, accepts Vec<Value> versus Vec<crate::Value> with no errors, and rejects fn versus query with the same Value result. These visible assertions cover both independent requirements and semantic result equality. Captured check setup parses a valid demo crate with Value declared and invokes validate. All associated inputs were inspected; no TODO/N/A entries or deferred prerequisites exist. Baseline: independently verified exact byte equality of both current source files with the historical snapshots by joining stored lines; the earlier rationale remains supported by current code and assertions. Execution: I ran review start/read and snapshot comparison, and am recording this report; I did not run tests or a workspace build. The coordinator separately reports 321 functional tests and a root cargo build passing, which is not my execution evidence. No edits required.

Browse meta anchors

116 anchors

Specification anchors and declared coverage
AnchorImplementationTests
meta (116)102 Implemented24 TODO103 Implemented36 TODO
meta.anchors (22)22 Implemented21 Implemented12 TODO
anchor_pagesImplementedImplementedTODO
book_explorerImplementedImplementedTODO
canonical_sourcesImplementedImplementedTODO
meta.anchors.content (7)7 Implemented7 Implemented
blocksImplementedImplemented
explicit_endImplementedImplemented
headingImplementedImplemented
literal_syntaxImplementedImplemented
next_anchorImplementedImplemented
source_endImplementedImplemented
unmatched_endImplementedImplemented
context_navigationImplementedImplementedTODO
evidence_statusImplementedImplementedTODO
explorer_navigationImplementedTODO
implementation_coverageImplementedImplementedTODO
implementation_referencesImplementedImplementedTODO
placeholder_statusImplementedImplementedTODO
point_excerptsImplementedImplementedTODO
region_balanceImplementedImplemented
region_excerptsImplementedImplementedTODO
test_coverageImplementedImplemented
test_referencesImplementedImplemented
unique_namesImplementedImplementedTODO
meta.book (21)10 Implemented18 TODO12 Implemented18 TODO
anchor_movesImplementedTODOImplementedTODO
authorityImplementedTODOImplementedTODO
browser_deliveryTODOImplementedTODO
browser_dependenciesTODOTODO
browser_rust_sourceTODOTODO
browser_searchTODOTODO
browser_serveTODOTODO
browser_structureTODOTODO
chapter_namesImplementedTODOImplementedTODO
crate_ownershipImplementedImplemented
crates_landingImplementedImplemented
entity_linksTODOTODO
index_groupsImplementedTODOImplementedTODO
index_namespace_pagesImplementedImplemented
index_rowsImplementedTODOImplementedTODO
index_statusImplementedTODOImplementedTODO
rfd_changesTODOTODO
sage_chaptersTODOImplementedTODO
self_descriptionTODOTODO
shared_modelImplementedTODOImplementedTODO
source_rolesTODOTODO
meta.contracts (4)4 Implemented3 TODO4 Implemented3 TODO
cache_invocationsImplementedTODOImplementedTODO
correspondenceImplementedImplemented
observation_coverageImplementedTODOImplementedTODO
validated_sessionImplementedTODOImplementedTODO
meta.language (39)39 Implemented39 Implemented
meta.language.calls (2)2 Implemented2 Implemented
declaredImplementedImplemented
forbiddenImplementedImplemented
meta.language.classes (3)3 Implemented3 Implemented
abstract_completeImplementedImplemented
override_signatureImplementedImplemented
single_inheritanceImplementedImplemented
meta.language.contexts (1)1 Implemented1 Implemented
inheritanceImplementedImplemented
meta.language.envelopes (7)7 Implemented7 Implemented
class_callsImplementedImplemented
createsImplementedImplemented
direct_callsImplementedImplemented
leafImplementedImplemented
permissionsImplementedImplemented
readsImplementedImplemented
receiver_callsImplementedImplemented
meta.language.fields (2)2 Implemented2 Implemented
context_stateImplementedImplemented
kindsImplementedImplemented
meta.language.methods (2)2 Implemented2 Implemented
kindsImplementedImplemented
proseImplementedImplemented
meta.language.model (3)3 Implemented3 Implemented
forbidden_pathsImplementedImplemented
inherited_prohibitionsImplementedImplemented
virtual_dispatchImplementedImplemented
meta.language.types (19)19 Implemented19 Implemented
argument_arityImplementedImplemented
declaration_proseImplementedImplemented
enum_variantsImplementedImplemented
field_proseImplementedImplemented
generic_parametersImplementedImplemented
member_commasImplementedImplemented
name_resolutionImplementedImplemented
opaque_representationImplementedImplemented
preludeImplementedImplemented
qualified_namesImplementedImplemented
recursive_valuesImplementedImplemented
struct_fieldsImplementedImplemented
tuplesImplementedImplemented
type_expressionsImplementedImplemented
unique_fieldsImplementedImplemented
unique_parametersImplementedImplemented
unique_variantsImplementedImplemented
unknown_namesImplementedImplemented
variant_proseImplementedImplemented
meta.reviews (27)27 Implemented27 Implemented
claim_textImplementedImplemented
complete_test_setImplementedImplemented
decisionsImplementedImplemented
fragment_associationsImplementedImplemented
fragment_formatImplementedImplemented
fragment_freshnessImplementedImplemented
gateImplementedImplemented
input_formatImplementedImplemented
input_fragmentsImplementedImplemented
output_formatImplementedImplemented
preparationImplementedImplemented
record_requiredImplementedImplemented
recorded_readsImplementedImplemented
recordingImplementedImplemented
review_delegationImplementedImplemented
review_diagnosticsImplementedImplemented
review_instructionsImplementedImplemented
review_scopeImplementedImplemented
selector_claimImplementedImplemented
selector_line_rangeImplementedImplemented
selector_testImplementedImplemented
selector_whole_fileImplementedImplemented
source_representationImplementedImplemented
stalenessImplementedImplemented
summary_formatImplementedImplemented
test_sourceImplementedImplemented
validation_layoutImplementedImplemented
meta.validation (3)3 TODO3 TODO
claim_specific_evidenceTODOTODO
independent_inspectionTODOTODO
review_packetsTODOTODO