meta.reviews.selector_line_range

Selector::LineRange { start, end } selects a one-based, inclusive range of lines within the fragment’s source file. Lines are delimited by \n; selected text retains the original line endings, including the last selected line’s ending if present. Zero, reversed, or out-of-bounds ranges are invalid. The saved line numbers are used again when checking freshness, so shifting content across those boundaries may conservatively make the fragment stale.

Read in specification context · design/meta/reviews.md

Implementation

Implemented crates/sage-meta/src/review.rs:326–331

sage_meta::review · lib:sage_meta

#![allow(unused)]
fn main() {
        // {anchor}`meta.reviews.selector_line_range`
        Selector::LineRange { start, end } => {
            let source = std::fs::read_to_string(resolved)?;
            let lines: Vec<_> = source.split_inclusive('\n').collect();
            if *start == 0 || end < start || *end > lines.len() {
                return Err("invalid or out-of-bounds line range".into());

}

See more source ↗

Tests and review

Indexed tests and the implementation-completeness and test-adequacy review; no test run is implied.

Implemented sage_meta::whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits

crates/sage-meta/tests/review.rs · test:review

#![allow(unused)]
fn main() {
#[test]
#[sage::test(meta.reviews.selector_whole_file)]
#[sage::test(meta.reviews.selector_line_range)]
#[sage::test(meta.reviews.recorded_reads)]
#[sage::test(meta.reviews.fragment_freshness)]
#[sage::test(meta.reviews.input_format)]
#[sage::test(meta.reviews.input_fragments)]
#[sage::test(meta.reviews.source_representation)]
#[sage::test(meta.reviews.staleness)]
fn whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits() {
    let fixture = Fixture::new();
    fixture.start();
    fixture.write("helper.txt", "first\r\n\r\nthird\nlast");
    assert_eq!(
        review::capture_read(
            &fixture.0,
            "demo.rule",
            "helper.txt",
            Selector::LineRange { start: 1, end: 2 }
        )
        .unwrap(),
        "first\r\n\r\n"
    );
    assert_eq!(
        review::capture_read(
            &fixture.0,
            "demo.rule",
            "helper.txt",
            Selector::LineRange { start: 4, end: 4 }
        )
        .unwrap(),
        "last"
    );
    for (start, end) in [(0, 1), (3, 2), (1, 5), (5, 5)] {
        assert!(
            review::capture_read(
                &fixture.0,
                "demo.rule",
                "helper.txt",
                Selector::LineRange { start, end }
            )
            .is_err()
        );
    }
    review::record(&fixture.0, "demo.rule", &Fixture::report()).unwrap();
    fixture.write("helper.txt", "first\r\n\r\nUNSELECTED\nlast");
    assert!(sage_meta::check(&fixture.0).is_valid());
    fixture.write("helper.txt", "changed\r\n\r\nthird\nlast");
    assert!(!sage_meta::check(&fixture.0).is_valid());
    fixture.start();
    for _ in 0..2 {
        assert_eq!(
            review::capture_read(&fixture.0, "demo.rule", "helper.txt", Selector::WholeFile)
                .unwrap(),
            "changed\r\n\r\nthird\nlast"
        );
    }
    let input = fixture.input();
    let tail = &input.fragments[input.fragments.len() - 2..];
    assert_eq!(tail[0], tail[1]);
    assert_eq!(tail[0].contents.join("\n"), "changed\r\n\r\nthird\nlast");
    review::record(&fixture.0, "demo.rule", &Fixture::report()).unwrap();
    fixture.write("helper.txt", "changed\r\n\r\nthird\nlast\n");
    assert!(!sage_meta::check(&fixture.0).is_valid());
}
}

See more source ↗

Review: Accepted · final_quality.

Reviewed the complete meta.reviews.selector_line_range claim, associated review.rs implementation and full whole_files_and_ranges_preserve_exact_line_endings_and_detect_selected_edits test. This is source inspection; no behavior tests were run by this reviewer.

select resolves the fragment's file and uses split_inclusive on newline, preserving carriage returns and each actual terminating newline. It rejects start=0, end<start and end beyond the physical line count before slicing lines[start-1..end] and concatenating, which implements one-based inclusive bounds. A final unterminated line remains selectable without adding an ending; a trailing newline does not invent another selectable empty line. capture_read saves the unchanged LineRange selector and exact reversible source_lines. Freshness calls select again with those saved numbers rather than relocating text, so shifts across the fixed boundaries can conservatively change the selection and make it stale. This is intentional positional selection, not semantic tracking.

The associated test writes mixed-ending source with a CRLF blank line, LF third line and unterminated fourth line. It asserts lines 1–2 equal exactly first CRLF plus blank CRLF, and line 4 equals exactly last with no ending. Four negative ranges cover zero, reversed, an end beyond EOF and a start beyond EOF. After recording, editing unselected line 3 preserves validity while changing selected line 1 invalidates it, demonstrating that the saved range rather than the entire file is rechecked. The later WholeFile portion asserts repeated exact capture and terminal-newline freshness; it is additional representation evidence, not misreported as a range-shift execution. Fixed-number reuse under shifting is directly visible in the saved-selector/reselect implementation. Captured Fixture/TEST and shared check helpers show real saved reviews and gate calls, with assertions visible in the annotated body.

All claim requirements are accounted for: delimiter, one-based inclusive semantics, original endings, invalid bounds and positional freshness. No TODO/N/A entries or concrete defect were found. No source changes or additional edits are requested.

Browse meta anchors

116 anchors

Anchor Implementation Tests

meta (116) 102 Implemented24 TODO 103 Implemented36 TODO

meta.anchors (22) 22 Implemented 21 Implemented12 TODO

anchor_pages Implemented ImplementedTODO

Every specification anchor has a stable page identifying the rule and showing its definition, context, implementation entries, and tests/evidence. The page includes Rust excerpts and access to surrounding source, and exposes each entry’s placeholder status and explanation. Multiple sites remain individually inspectable rather than being reduced to a single coverage badge.

Symposiun AGentic Environment (SAGE)

meta.reviews.selector_line_range

Implementation

Tests and review